dockersamples / example-voting-app

Example distributed app composed of multiple containers for Docker, Compose, Swarm, and Kubernetes
Apache License 2.0
4.75k stars 10.99k forks source link

use GHA to update Docker Hub repo description #289

Open BretFisher opened 1 year ago

BretFisher commented 1 year ago

Currently, when we update the README.md in this repo, it doesn't update the readme in Docker Hub.

Making a workflow for this that only fires on changing README.me would fix that:

https://github.com/peter-evans/dockerhub-description

sumitNITS commented 1 year ago

Hi @BretFisher,

I would like to work on this task. You can assign it to me!

Thanks, and have a good day ahead!

sumitNITS commented 1 year ago

/assign

sumitNITS commented 1 year ago

Hi @BretFisher,

I have gone through https://github.com/peter-evans/dockerhub-description and in the case of example-voting-app repo it is having 3 docker images (3 repos) dockersamples/examplevotingapp_vote, dockersamples/examplevotingapp_worker and dockersamples/examplevotingapp_result in docker hub.

Following the peter-evans dockerhub-description I tried to achieve this goal (locally in example scenarios with more than one repo in docker hub ). Since we are having 3 docker images in 3 repos so the parameter "repository" was not taking more than one docker hub repo at the same time. image

So what is your suggestion on this?

However, we can go for 3 yaml files each containing the individual docker hub repo name OR another option is to maintain a single docker hub repo having images for vote, worker and result within its tag like dockersamples/examplevotingapp:vote, dockersamples/examplevotingapp:worker, dockersamples/examplevotingapp:result Following that way only 1 yaml file will work in this case!

Let me know your thoughts on this!

sumitNITS commented 1 year ago

I could see the workflows for building images with separate yaml files for vote, worker, and result so suspecting that for this also you will go for 3 yaml files if I am going correctly.

Please let me know whether "${{ secrets.DOCKERHUB_TOKEN }}" that you are using in other workflows is having a personal access token as a secret.

@BretFisher I shall wait for your response soon!