search

dockersamples / example-voting-app

Example distributed app composed of multiple containers for Docker, Compose, Swarm, and Kubernetes
Apache License 2.0
4.75k stars 10.99k forks source link

Specify limit #302

Closed bondhan closed 1 year ago

bondhan commented 1 year ago

adding resource limit and setup cluster

mikesir87 commented 1 year ago

Hello and thank you for the PR!

While adding resource limits and requests are definitely a best practice, it does require having enough compute resources to actually deploy the application. Since many folks use this as a demo for deploying to k8s using Docker Desktop, this change would break those demos. And while your setup instructions are great, they are written to how you would deploy k8s. Seeing there are many ways to do so, we don't want to be too prescriptive.

Therefore, we're going to go ahead and close this PR. But, feel free to continue maintaining it in your own forked copy of the repo! Thanks again!