dockerzhang / incubator-inlong

Apache InLong - a one-stop data streaming platform
https://inlong.apache.org/
Apache License 2.0
0 stars 0 forks source link

[INLONG-90] Remove unused codes in TubeBroker #90

Closed dockerzhang closed 3 years ago

dockerzhang commented 3 years ago

1. TubeBroker implements Runnable interface, I think this is a little strange. If we have some extra work to do , we can create inner thread for it.
2. JVMClusterUtil is useless . If we support start more than one broker in one JVM, we have to change some params, we can't set different params for different brokers at the same time. And as we will support docker in the future, we decide to remove this class.
3. remove synchronized in start method.
4. remove below codes in stop method

if (this.shutdown.get()) {
    return;
}

5. remove unused run method.
6. remove unused waitForServerOnline method.

JIRA link - [INLONG-90] created by technoboy