search

dockfries / infernus

Node.js library for scripting Open Multiplayer.
https://dockfries.github.io/infernus/
MIT License
21 stars 2 forks source link

Eliminate unnecessary samp-node-lib code #1

Closed dockfries closed 2 years ago

dockfries commented 2 years ago

Nonsensical type declarations

  1. globals.d.ts, It is not clear what this variable does, and I think it can be removed.
  2. events.d.ts, Events constant be used for samp-node plugins that are globally declared in node's globals.
dockfries commented 2 years ago

Removable classes

DynamicObject To be precise, it is a movable object, because the call is still the original function, not streamer, plus the name and streamer objects are somewhat ambiguous on. getPlayers Unnecessary, you can remove or implement the relevant content on your own. getAllVehicle Same as above. SampPlayers Same as above. SampVehicles Same as above. SampPlayerNativeFunctions Same as above. SampVehicleNativeFunctions Same as above. SampNode There has been a type declaration in @sa-mp/node. Game.ts It's too confusing and pointless to pull out the implementation separately. For Gamemode only init, exit callbacks and functions make sense.

dockfries commented 2 years ago

Most of it done