dockhippie / elasticsearch

Docker images for elasticsearch
MIT License
10 stars 7 forks source link

Breaking changes since #6 #14

Closed vbabenkoru closed 2 years ago

vbabenkoru commented 2 years ago

We've been using the 5.6 image in our docker-compose, but since the changes in #6, our config doesn't work anymore and requires full reconfiguration. Is there a way to keep backwards-compatible images available under a different tag or something like that?

tboerger commented 2 years ago

What do you mean by it needs to be reconfigured? The environment variables should be working as before. Mostly the internal structuring of the image has changed.

vbabenkoru commented 2 years ago

We've been providing a custom config file to specify configs not covered by the environment variables, and the new version is overwriting this file.

tboerger commented 2 years ago

In that case you could provide the env variable ELASTICSEARCH_SKIP_TEMPLATES=true, but in that case you also got to provide the jvm.options file, this is witten or skipped at https://github.com/dockhippie/elasticsearch/blob/master/v5.6/overlay/etc/container.d/15-config.sh