docking-org / OICR-ZINC

Exported files from ZINC for use in OICR ICGC DCC and Collaboratory
1 stars 3 forks source link

atc_classifications split into two fields #3

Closed junjun-zhang closed 8 years ago

junjun-zhang commented 8 years ago

Before moving to GitHub, there is one field for atc code:

   "atc_classifications": [
      {
           "level4": "L01AA",
           "level4_description": "Nitrogen mustard analogues",
           "level5": "L01AA07",
           "who_name": "trofosfamide"
       }
   ],

What's in the git repo now:

   "atc_codes": [
       {
           "code": "L01AA",
           "description": "Nitrogen mustard analogues"
       }
   ],
   "atc_level5_codes": [
       "L01AA07"
   ],

Can we merge these two into one field as before?

jir322 commented 8 years ago

Yes, sorry this got bungled as we moved into github. We'll push to github later today and let you know.

On Tue, Nov 24, 2015 at 2:26 PM, Junjun Zhang notifications@github.com wrote:

Before moving to GitHub, there is one field for atc code:

"atc_classifications": [ { "level4": "L01AA", "level4_description": "Nitrogen mustard analogues", "level5": "L01AA07", "who_name": "trofosfamide" } ],

What's in the git repo now:

"atc_codes": [ { "code": "L01AA", "description": "Nitrogen mustard analogues" } ], "atc_level5_codes": [ "L01AA07" ],

Can we merge these two into one field as before?

— Reply to this email directly or view it on GitHub https://github.com/docking-org/OICR-ZINC/issues/3.

jir322 commented 8 years ago

FIXED

teaguesterling commented 8 years ago

Solved by 5b5bae6849d1ac58b799219fccb461779e4300ae for the record