search

docknetwork / crypto-wasm-ts

Typescript abstractions over Rust crypto library's WASM wrapper
Apache License 2.0
27 stars 7 forks source link

Boolean value support #25

Closed cykoder closed 1 year ago

cykoder commented 1 year ago

Support for boolean values and boolean type in schema generation, encoded as positive integers. @lovesh let me know if i missed any area to test with this, or if there's a more appropriate encoder function.

Without boolean type support some credentials generate the schema with a boolean type as "string", which then fails schema validation on verification and ideally bools shouldn't be encoded as strings.

lovesh commented 1 year ago

Thanks. Minor comments but otherwise LGTM.