docknetwork / crypto

Rust crypto library for data privacy tools
Apache License 2.0
78 stars 21 forks source link

First part of if condition redundant #2

Closed EDGDrummond closed 1 month ago

EDGDrummond commented 2 years ago

https://github.com/docknetwork/crypto/blob/2eee4a6a6cba58c92e18ad5557d6b1a7a4730cfe/compressed_sigma/src/amortized_homomorphism.rs#L79

We check if witnesses.len() > j, but j < witnesses.len() by definition so this is trivially true.

esplinr commented 1 month ago

We made the change requested. Thank you for the report!