Coconut Proof allows empty blinding messages

docknetwork / crypto

Rust crypto library for data privacy tools

Apache License 2.0

78 stars 21 forks source link

Coconut Proof allows empty blinding messages #21

Closed 0xvon closed 8 months ago

0xvon commented 8 months ago

Issue

https://github.com/docknetwork/crypto/issues/20

What I do

change UnpackedBlindedMessages impl to return empty proof even if blinding message is empty
change ps_proof's proving to use the index not i but j

0xvon commented 8 months ago

@lovesh Thank you so much for your quick feedbacks! I modified for all of your comments!

lovesh commented 8 months ago

@0xvon I have fixed the failing tests in this commit but I am not able to edit this PR even when this PR is marked appropriately. Can you please get these changes in your PR? Thanks

0xvon commented 8 months ago

@0xvon I have fixed the failing tests in this commit but I am not able to edit this PR even when this PR is marked appropriately. Can you please get these changes in your PR? Thanks

I pushed!

lovesh commented 8 months ago

Thank you @0xvon for the contribution.