search

docksal / addons

Community driven, submit your addon! Docksal addons that can be installed via `fin addon install` command.
MIT License
16 stars 34 forks source link

drupal-check addon #44

Closed ghost closed 3 years ago

ghost commented 5 years ago

In preparation for the eventual upgrade from Drupal 8 to Drupal 9 Matt Glaman (mglaman) has created a drupal-check script built on PHPStan to help developers and module maintainers prepare their code. Dries has also talked about this in his post How to prepare for Drupal 9

Matt Glaman' drupal-check script analyzes modules on a site searching for any deprecated code that would otherwise cause a site to fail after upgrading.

This addon puts a wrapper around the drupal-check script allowing anyone who is currently using docksal to begin preparing their site for Drupal 9 quickly.

ghost commented 5 years ago

I would've created the PR against a develop branch, but I didn't see one for the addons.

achekulaev commented 5 years ago

Not sure why you created draft PR

ghost commented 5 years ago

I can change it to a normal PR, I was just gauging interest for the add on.

achekulaev commented 5 years ago

The repo is pretty open to propositions. Any addon that is not harmful and makes sense will be approved.

acondura commented 5 years ago

I am definitely interested in this!

lpeabody commented 5 years ago

Possibility of getting this in? Would be a handy tool for our projects.

achekulaev commented 5 years ago

@cbarrettgenuine ok got to reviewing it, sorry for the delay. Please see comments and propositions above.

In addition to the above, please add this addon to the list of addons in global README file.

achekulaev commented 5 years ago

@cbarrettgenuine ready when you are!

lmakarov commented 5 years ago

Note: drupal-check binary will ship by default in docksal/cli starting with v2.9.0 https://github.com/docksal/service-cli/pull/139

JDDoesDev commented 4 years ago

Note: drupal-check binary will ship by default in docksal/cli starting with v2.9.0 docksal/service-cli#139

I'll remove the call to install the binary and update the code accordingly

achekulaev commented 3 years ago

seems stale