search

docksal / addons

Community driven, submit your addon! Docksal addons that can be installed via `fin addon install` command.
MIT License
16 stars 34 forks source link

Coder addon #47

Closed acondura closed 4 years ago

acondura commented 4 years ago

Coder addon using a fork of https://github.com/cdr/code-server, which fixes the "Insufficient permission" error on save.

achekulaev commented 4 years ago

@lmakarov is it properly using the IDE option?

acondura commented 4 years ago

I'll be applying a few more fixes this week and also test out the latest version 2 of code server which they say "uses the new web and remote functionality VS Code has implemented which has made it possible to shrink the code base by about a factor of ten. It should be much easier to upgrade VS Code versions now and it'll fix a decent number of issues." https://github.com/cdr/code-server/pull/857

achekulaev commented 4 years ago

Keep us posted

acondura commented 4 years ago

V2 of code-server (https://hub.docker.com/r/codercom/code-server/tags) indeed runs a bit smoother. I'm adding some finishing touches to the addon and I'll push an updated version this week.

lmakarov commented 4 years ago

@lmakarov is it properly using the IDE option?

@achekulaev this addon and the stock IDE option in docksal/cli are not related.

@acondura the latest versions of docksal/cli (v2.9.0, just released) now ships with VS Code Server v1 (v2 does not work with xdebug) preinstalled.

Steps to enable the integration:

  1. Update to the latest dev version of Docksal
DOCKSAL_VERSION=develop fin update
  1. Update your project stack configuration
fin config set CLI_IMAGE=docksal/cli:2.9-php7.3
fin config set --env=local IDE_ENABLED=1
fin config set --env=local XDEBUG_ENABLED=1
fin project start

I recorded a quick video to demo the upcoming functionality: https://youtu.be/3hHDoXlqeJ8

@acondura you are welcome to contribute to docksal/cli with further VS Code Server integration updates (e.g. updating to v2 and fixing xdebug).

acondura commented 4 years ago

Niceeeee! Glad to hear it's in docksal/cli and that it's using the 'ide-' prefix. I'll definitely look into v2 and xdebug.

lmakarov commented 4 years ago

With VS Code bundled in docksal/cli, I don't see a need in the coder addon. Closing.

acondura commented 4 years ago

@lmakarov Curious, I followed all the steps you listed and I constantly get:

Pulling cli (docksal/cli:2.9-ide)... ERROR: manifest for docksal/cli:2.9-ide not found: manifest unknown: manifest unknown

achekulaev commented 4 years ago

@acondura you have older overrides-ide.yml stack file. You'll be able to test when we release RC