search

docksal / addons

Community driven, submit your addon! Docksal addons that can be installed via `fin addon install` command.
MIT License
16 stars 34 forks source link

Standarize domain names for addons to not use a subdomain of a project domain name #56

Closed frederickjh closed 4 years ago

frederickjh commented 4 years ago

Some addons use a subdomain of the ${VIRTUAL_HOST}, but if you are using a LetsEncrypt Wildcard domain for your Docksal projects it is only good for one level of subdomain not two.

ie. LetsEncrypt wildcard domain certificate is for *.dev.example.com, so it would be valid for the projects listed below but not for Docksal addons that use a domain name that is a subdomain of a subdomain of dev.example.com

Projects are at:

Not valid with wildcard certificate:

If a dash is used instead of a period a subdomain is used that is valid for the wildcard certificate.

Valid with wildcard certificate:

I believe I suggested using a dash instead of a period for the IDE and it is configured so.

I know that the following addons need this change:

frederickjh commented 4 years ago

@achekulaev I take it that you checked through the other addons or know that they have switched to use a prefix on the project name as their subdomain name instead of using a subdomain name of the project subdomain name, since you closed this.

achekulaev commented 4 years ago

@frederickjh well I see the addons you mentioned are covered. I have not checked through other addons. (and frankly have no intention of doing so, this is kind of community-supported repo)

frederickjh commented 4 years ago

OK @achekulaev I will take a look and see what I can find.

frederickjh commented 4 years ago

The pma addon is the only other addon that I could find using a subdomain of the project subdomain name. I will see what I can do about submitting a pull request for it. The rest of the addons either do not use a web interface or have been changed to use a prefix to the project name.