search

docksal / addons

Community driven, submit your addon! Docksal addons that can be installed via `fin addon install` command.
MIT License
16 stars 34 forks source link

Mailhog addon script still adds mhsendmail #69

Closed hamletta closed 6 months ago

hamletta commented 4 years ago

Description

Problem/feature description... When you run the addon script to add Mailhog, it adds the mhsendmail setting to php.ini

Steps to reproduce the issue:

  1. Run "fin addon install mailhog"

Describe the results you received:

Results... php.ini has the line: sendmail_path = '/usr/local/bin/mhsendmail --smtp-addr=mail:1025

Describe the results you expected:

Expected behavior...

If I understand correctly, Docksal shouldn't write that line to php.ini, since it's moved from mhsendmail to msmtp.

Thanks, hamletta

Output of fin config:

fin config output Docker Compose configuration --------------------- services: cli: dns: - 192.168.64.100 - 8.8.8.8 environment: BLACKFIRE_CLIENT_ID: null BLACKFIRE_CLIENT_TOKEN: null COMPOSER_ALLOW_XDEBUG: '0' COMPOSER_DISABLE_XDEBUG_WARN: '0' DOCROOT: web DRUSH_ALLOW_XDEBUG: '0' DRUSH_OPTIONS_URI: room.docksal GIT_USER_EMAIL: luxford_rebecca@bah.com GIT_USER_NAME: Rebecca Luxford HOST_GID: '20' HOST_UID: '501' MYSQL_DATABASE: default MYSQL_HOST: db MYSQL_PASSWORD: user MYSQL_ROOT_PASSWORD: root MYSQL_USER: user PHP_IDE_CONFIG: null SECRET_ACAPI_EMAIL: null SECRET_ACAPI_KEY: null SECRET_ACQUIACLI_KEY: null SECRET_ACQUIACLI_SECRET: null SECRET_PLATFORMSH_CLI_TOKEN: null SECRET_SSH_PRIVATE_KEY: null SECRET_TERMINUS_TOKEN: null SSH_AUTH_SOCK: /.ssh-agent/proxy-socket VIRTUAL_HOST: room.docksal XDEBUG_CONFIG: remote_connect_back=0 remote_host=192.168.64.1 XDEBUG_ENABLED: '0' hostname: cli image: docksal/cli:2.11-php7.3 labels: io.docksal.shell: bash io.docksal.user: docker logging: options: max-file: '10' max-size: 1m volumes: - docksal_ssh_agent:/.ssh-agent:ro - /Users/rebeccaluxford/.docksal/tmp/room:/Users/rebeccaluxford/.docksal/tmp/room:ro - cli_home:/home/docker:rw - project_root:/var/www:rw,nocopy,cached db: dns: - 192.168.64.100 - 8.8.8.8 environment: MYSQL_ALLOW_EMPTY_PASSWORD: null MYSQL_DATABASE: default MYSQL_INITDB_SKIP_TZINFO: null MYSQL_ONETIME_PASSWORD: null MYSQL_PASSWORD: user MYSQL_RANDOM_ROOT_PASSWORD: null MYSQL_ROOT_PASSWORD: root MYSQL_USER: user hostname: db image: docksal/mysql:5.6-1.5 logging: options: max-file: '10' max-size: 1m ports: - 3306/tcp volumes: - db_data:/var/lib/mysql:rw - project_root:/var/www:ro,nocopy,cached mail: dns: - 192.168.64.100 - 8.8.8.8 hostname: mail image: mailhog/mailhog labels: io.docksal.cert-name: none io.docksal.virtual-host: mail.room.docksal,mail.room.docksal.* io.docksal.virtual-port: '8025' logging: options: max-file: '10' max-size: 1m volumes: - project_root:/var/www:ro,nocopy,cached web: depends_on: cli: condition: service_started dns: - 192.168.64.100 - 8.8.8.8 environment: APACHE_BASIC_AUTH_PASS: null APACHE_BASIC_AUTH_USER: null APACHE_DOCUMENTROOT: /var/www/web APACHE_FCGI_HOST_PORT: cli:9000 hostname: web image: docksal/apache:2.4-2.3 labels: io.docksal.cert-name: none io.docksal.permanent: "false" io.docksal.project-root: /Users/rebeccaluxford/Projects/room io.docksal.virtual-host: room.docksal,*.room.docksal,room.docksal.* logging: options: max-file: '10' max-size: 1m volumes: - project_root:/var/www:ro,nocopy,cached version: '2.1' volumes: cli_home: {} db_data: {} docksal_ssh_agent: external: true name: docksal_ssh_agent project_root: driver: local driver_opts: device: /Users/rebeccaluxford/Projects/room o: bind type: none ---------------------


Output of fin sysinfo:

fin sysinfo output ███ OS Darwin Mac OS X 10.15.6 Darwin bah5cg8051630.resource.ds.bah.com 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64 ███ ENVIRONMENT MODE : Docker Desktop ███ FIN fin version: 1.99.0 ███ DOCKER COMPOSE EXPECTED VERSION: 1.26.0 docker-compose version 1.26.0, build d4451659 docker-py version: 4.2.1 CPython version: 3.7.7 OpenSSL version: OpenSSL 1.1.1g 21 Apr 2020 ███ DOCKER EXPECTED CLIENT VERSION: 19.03.9 EXPECTED SERVER VERSION: 19.03.8 Client: Docker Engine - Community Version: 19.03.9 API version: 1.40 Go version: go1.13.10 Git commit: 9d988398e7 Built: Fri May 15 00:23:14 2020 OS/Arch: darwin/amd64 Experimental: false Server: Docker Engine - Community Engine: Version: 19.03.12 API version: 1.40 (minimum version 1.12) Go version: go1.13.10 Git commit: 48a66213fe Built: Mon Jun 22 15:49:27 2020 OS/Arch: linux/amd64 Experimental: false containerd: Version: v1.2.13 GitCommit: 7ad184331fa3e55e52b890ea95e65ba581ae3429 runc: Version: 1.0.0-rc10 GitCommit: dc9208a3303feef5b3839f4323d9beb36df0a9dd docker-init: Version: 0.18.0 GitCommit: fec3683 ███ DOCKSAL: PROJECTS project STATUS virtual host project root room Up About an hour (healthy) room.docksal,*.room.docksal,room.docksal.* /Users/rebeccaluxford/Projects/room ███ DOCKSAL: VIRTUAL HOSTS *.room.docksal mail.room.docksal.* mail.room.docksal room.docksal.* room.docksal ███ DOCKSAL: NETWORKING DOCKSAL_IP: 192.168.64.100 DOCKSAL_VHOST_PROXY_IP: 0.0.0.0 DOCKSAL_DNS_IP: 0.0.0.0 DOCKSAL_DNS_DISABLED: 0 DOCKSAL_NO_DNS_RESOLVER: 0 DOCKSAL_DNS_UPSTREAM: DOCKSAL_DNS_DOMAIN: docksal Checking connectivity to http://dns-test.docksal... Host: PASS Containers: PASS ███ DOCKER: RUNNING CONTAINERS CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 3b1c23420006 mailhog/mailhog "MailHog" 17 hours ago Up About an hour 1025/tcp, 8025/tcp room_mail_1 95430060e943 docksal/ssh-agent:1.3 "docker-entrypoint.s…" 19 hours ago Up 19 hours (healthy) docksal-ssh-agent 5498471fcc38 docksal/dns:1.1 "docker-entrypoint.s…" 19 hours ago Up 19 hours (healthy) 0.0.0.0:53->53/udp docksal-dns 440ea6b4184a docksal/vhost-proxy:1.6 "docker-entrypoint.s…" 19 hours ago Up 19 hours (healthy) 0.0.0.0:80->80/tcp, 0.0.0.0:443->443/tcp docksal-vhost-proxy 2dd01f240d73 docksal/mysql:5.6-1.5 "docker-entrypoint.s…" 20 hours ago Up About an hour (healthy) 0.0.0.0:32770->3306/tcp room_db_1 73d9245d1ee6 docksal/apache:2.4-2.3 "httpd-foreground" 20 hours ago Up About an hour (healthy) 80/tcp, 443/tcp room_web_1 57e17152942d docksal/cli:2.11-php7.3 "/opt/startup.sh sup…" 20 hours ago Up About an hour (healthy) 22/tcp, 3000/tcp, 9000/tcp room_cli_1 ███ DOCKER: NETWORKS NETWORK ID NAME DRIVER SCOPE 70cf031a1a88 _default bridge local 8b8bef0e3eb3 abby_default bridge local 9c7238c40a9a bridge bridge local abd1285d79c9 db-test_default bridge local 8c7ca504fc17 docksal-behat-example_default bridge local c1d2e45db962 dol-scaffold_default bridge local f2a6c5a3d1eb glitch_default bridge local 20cd15304172 host host local 7468d7e42ce1 none null local 9d2dda905955 room_default bridge local 993c09a3b388 udem_default bridge local ███ DOCKER DESKTOP EXPECTED VERSION: 2.1.0.5 DETECTED VERSION: 2.3.0.5 ███ HDD Usage Filesystem Size Used Avail Capacity iused ifree %iused Mounted on /dev/disk1s5 466Gi 10Gi 329Gi 4% 488421 4881964459 0% / devfs 189Ki 189Ki 0Bi 100% 654 0 100% /dev /dev/disk1s1 466Gi 117Gi 329Gi 27% 1734591 4880718289 0% /System/Volumes/Data /dev/disk1s4 466Gi 8.0Gi 329Gi 3% 8 4882452872 0% /private/var/vm map auto_home 0Bi 0Bi 0Bi 100% 0 0 100% /System/Volumes/Data/home /dev/disk1s3 466Gi 504Mi 329Gi 1% 54 4882452826 0% /Volumes/Recovery
lmakarov commented 6 months ago

MailHog was replaced with Mailpit (https://github.com/docksal/addons/pull/95)