search

docksal / addons

Community driven, submit your addon! Docksal addons that can be installed via `fin addon install` command.
MIT License
16 stars 34 forks source link

Need to check for "Up" when detecting container status #92

Closed KoalityJustin closed 4 months ago

KoalityJustin commented 10 months ago

It would seem Docksal cannot decide how it's going to report readiness in the status for a container, as now the status uses "Up" once again. Was changed in #86 but now that's preventing addons from installing for me.

Versions: Docker version: v24.0.6 Docksal version: v1.18.2 fin version: v1.113.2

Output from fin ps:

⇒  fin ps               
NAME                           IMAGE                      COMMAND                  SERVICE             CREATED             STATUS                    PORTS
testsite_cli_1             docksal/cli:php8.1-3.3     "/opt/startup.sh sup…"   cli                 3 minutes ago       Up 3 minutes (healthy)    22/tcp, 3000/tcp, 9000/tcp
testsite_db_1              docksal/mariadb:10.6-1.3   "docker-entrypoint.s…"   db                  25 minutes ago      Up 25 minutes (healthy)   0.0.0.0:32861->3306/tcp, :::32861->3306/tcp
testsite_elasticsearch_1   elasticsearch:7.17.13      "/bin/tini -- /usr/l…"   elasticsearch       3 minutes ago       Up 3 minutes              9300/tcp, 0.0.0.0:32862->9200/tcp, :::32862->9200/tcp
testsite_web_1             docksal/apache:2.4-2.5     "httpd-foreground"       web                 3 minutes ago       Up 3 minutes (healthy)    80/tcp, 443/tcp

So when trying to run fin addon install rabbitmq it throws:

⇒  fin addon install rabbitmq 
Downloading addon hook files...
  rabbitmq.pre-install
  rabbitmq.post-install
  rabbitmq.pre-uninstall
Running pre-install hook...
[PRE-INSTALL] ERROR: Start the project with fin start first
Pre-install hook has failed and aborted the installation.

because there is no "running" in the status anywhere anymore.