search

docksal / service-mysql

MySQL service images for Docksal
https://docksal.io
MIT License
0 stars 5 forks source link

Migrate from Travis CI to GitHub Actions #25

Closed lpeabody closed 2 years ago

lpeabody commented 3 years ago

Changes

lpeabody commented 3 years ago

https://github.com/docksal/service-mysql/runs/2453371055?check_suite_focus=true#step:9:122

The error here doesn't make sense to me. mysql-variables.txt looks identical to SHOW VARIABLES;.

lpeabody commented 3 years ago

If you have BATS installed locally and you run:

export VERSION=8.0 FROM=mysql:8.0
make
make test

It succeeds:

IMAGE=docksal/mysql:8.0 NAME=docksal-mysql-8.0 VERSION=8.0 ./tests/test.bats
 ✓ Container initialization
 ✓ Default database present
 ✓ Check variables
 ✓ Configuration overrides

4 tests, 0 failures

EDIT: Nevermind, it actually fails. I forgot to rerun make after switching from version 5.6 to running version 8.0 (so I didn't follow the steps above the first time... and then I followed the steps above and got the error).

lpeabody commented 3 years ago

According to https://stackoverflow.com/a/30074553/664881 utf8 is an alias for utf8mb3, which is the value you get when you query the variables on version 8 of the built container.

Also see https://dev.mysql.com/doc/refman/8.0/en/charset-unicode-utf8mb3.html. Seems to suggest this should switch to utf8mb4 from utf8mb3 since utf8mb3 is deprecated.