search

docksal / service-mysql

MySQL service images for Docksal
https://docksal.io
MIT License
0 stars 5 forks source link

Refactor MySQL images to preserve compatibility with upstream #8

Closed lmakarov closed 6 years ago

lmakarov commented 6 years ago

We keep a fork of docker-entrypoint.sh inside this repo and it needs to be updated once in a while as changes to this file happen upstream.

The upstream now has a better way to introduce overrides: https://github.com/docker-library/docs/blob/master/mysql/README.md#initializing-a-fresh-instance

We should refactor our images to use that approach

achekulaev commented 6 years ago

Should this one be closed as fixed?

lmakarov commented 6 years ago

Yeah, it was supposed to be automatically closed by the commit message, but that did not happen. Resolved via 2764ab10c2581fb1e9d4b008d9adf2553d2e7207