search

docksal / service-varnish

Varnish Docker image for Docksal
MIT License
2 stars 12 forks source link

Give users the ability to set the secret #9

Closed sean-e-dietrich closed 6 years ago

sean-e-dietrich commented 6 years ago

In the Drupal 7 varnish module it requires that for version 4 you have the ability to set the secret (it's required) and the set up for creating a secret right now is too laborious and confusing for someone who may not know how to.

lmakarov commented 6 years ago

@sean-e-dietrich please add the new variable in the docs.

lmakarov commented 6 years ago

It would also be lovely to have automated tests running for this repo. So while you are here, maybe you'd want to look at #6 and #7 ;)

sean-e-dietrich commented 6 years ago

@lmakarov I'd like to handle that as apart of it's own ticket if possible. I'm not 100% sure what is needed but would look into it.

achekulaev commented 6 years ago

Great one @sean-e-dietrich . Thanks!