docksal / service-vhost-proxy

Virtual host proxy service image for Docksal
http://docksal.io
MIT License
7 stars 14 forks source link

Increase proxy_buffer_size for projects with large header size #18

Closed asgorobets closed 6 years ago

asgorobets commented 6 years ago

Drupal 8 sets cache tags headers and cache contexts that can exceed the limit of 8k very easily. I propose to increase it to 16k at least

lmakarov commented 6 years ago

This change breaks tests. I remember this same issue from a while ago - it was not possible to set this buffer above 8k without breaking tests. Not sure why.

achekulaev commented 6 years ago

It does not build because there are several interdependent values in the configuration and to modify one others should be modified as well. Here is proper PR https://github.com/docksal/service-vhost-proxy/pull/19

"256k should be enough for everyone" ©

lmakarov commented 6 years ago

Thanks @asgorobets and @achekulaev. Closing in favor of #19