search

docksal / service-vhost-proxy

Virtual host proxy service image for Docksal
http://docksal.io
MIT License
7 stars 14 forks source link

Change to DOCKSAL_DNS_DOMAIN doesn't change virtual hosts on projects. #38

Closed sean-e-dietrich closed 4 years ago

sean-e-dietrich commented 5 years ago

If you set DOCKSAL_DNS_DOMAIN to a value of 1.1.1.1.nip.io run fin system reset vhost-proxy then create projects this works and takes the domain into account.

But if you have existing projects set to the old value the existing projects will not take the change. You have to reset the project. This becomes an issue in sandboxes if the project is off you cannot access it from the old nor new value.

lmakarov commented 5 years ago

@sean-e-dietrich docksal-vhost-proxy has no concern over DNS_DOMAIN (or DOCKSAL_DNS_DOMAIN) variables.

Ingress routing is done based on the io.docksal.virtual-host label on containers. The label is normally configured via the VIRTUAL_HOST variables in the project stack configuration.

What do you get in fin config | grep VIRTUAL_HOST output for the affected sandbox?

sean-e-dietrich commented 5 years ago

I realize it seems odd that I put it here. But, the situation I ran into was I changed it within the ~/.docksal/docksal.env and then would have assumed that vhost proxy would have remapped the virtual hosts when running fin system reset vhost-proxy

lmakarov commented 4 years ago

@sean-e-dietrich is this till something worth looking into?

sean-e-dietrich commented 4 years ago

@lmakarov I believe so but there is a more likely chance that the variable is set at the beginning and this is a limitation. I think we can close this as the easiest and simplest solution is to just reset the web container. Do you think so?