Rework loading and not-found page

docksal / service-vhost-proxy

Virtual host proxy service image for Docksal

http://docksal.io

MIT License

7 stars 14 forks source link

Rework loading and not-found page #42

Closed achekulaev closed 5 years ago

achekulaev commented 5 years ago

cc @sean-e-dietrich

lmakarov commented 5 years ago

@achekulaev looks cool!

I'd like to have both pages using the same "theme" (including images and animations). We could use the animation you proposed for the landing page and seek designer help, using it as the base for the not-found static page.

achekulaev commented 5 years ago

@lmakarov ping

achekulaev commented 5 years ago

@lmakarov I don't understand why they fail. it is something unrelated to this PR

lmakarov commented 5 years ago

@achekulaev Test were failing because the content of the load/not-found pages changed. I updates those test cases and they pass now. However, images and styles are not loaded correctly when I'm reviewing this locally:

restarting project page - http://take.ms/7HAgF
not found project page - http://take.ms/IMKbX

This will need to be fixed in the nginx config. Not sure how tricky this would be. (This might be the reason why I originally decided to reference external images)

achekulaev commented 5 years ago

I don't know how you figured that was the string mismatch that broke tests. The tests output makes no sense to me https://travis-ci.org/docksal/service-vhost-proxy/builds/489164783#L809 It is not related to string mismatch at all. (hate Bats) Thanks anyways!

I made loading.html and not-found.html into statically built pages with no external dependencies and made an automation (see make html) to build their "dynamically linked" templates into those static pages, so that in case we need to alter them in future it was simple.