search

docksal / service-vhost-proxy

Virtual host proxy service image for Docksal
http://docksal.io
MIT License
7 stars 14 forks source link

docker-gen templates optimization #46

Closed achekulaev closed 5 years ago

achekulaev commented 5 years ago

Currently vhost-proxy spikes up to 50%-ish usage on a single CPU every 5 seconds resulting in a small but noticeable host CPU usage over time. It was already noted in #44

dockstation 2019-03-07 12-16-58

My guess is that template optimization, especially https://github.com/docksal/service-vhost-proxy/blob/develop/conf/nginx/conf.d/vhosts.conf.tmpl could reduce that number.

Creating the issue here to track progress and possibly do it, if creating v2 will take too long

lmakarov commented 5 years ago

The issue with the CPU spikes was related to the healthcheck script and not to docker-gen.

It has been addressed in docksal/service-vhost-proxy#48 and released as a hotfix in docksal/vhost-proxy v1.5.1.

Run fin update to get the fix.