docksal / service-vhost-proxy

Virtual host proxy service image for Docksal

http://docksal.io

MIT License

7 stars 14 forks source link

Ports project volume cleanup from docksal#1058 #51

Closed lpeabody closed 4 years ago

lpeabody commented 4 years ago

Changes

All project_root named volumes were leftover after proxyctl cleanup ran, even for projects that no longer exist. After discussing with @lmakarov, backporting the change in https://github.com/docksal/docksal/pull/1058/files#diff-41adca34c3eac75ca9453c7cb0634f6aR1285 makes sense to have here.

lpeabody commented 4 years ago

Alternatively, we could replace:

    log "Removing dangling volumes..."
    docker volume prune -f

with:

    log "Removing dangling volumes..."
    docker volume ls -qf dangling=true | xargs -r docker volume rm

lmakarov commented 4 years ago

We cannot use docker volume ls -qf dangling=true | xargs -r docker volume rm due to https://github.com/docksal/docksal/issues/1056. It can only be used as a one-time fix if you know what you are doing.