search

docksal / service-vhost-proxy

Virtual host proxy service image for Docksal
http://docksal.io
MIT License
7 stars 14 forks source link

Update docker-gen to 0.7.6 #69

Closed EggieCode closed 3 years ago

EggieCode commented 3 years ago

If you are running a newer function of docker docker-gen won't generate the correct upstream IP's. The is fixed in docker-gen 0.7.5: https://github.com/jwilder/docker-gen/pull/335 & https://github.com/jwilder/docker-gen/pull/336.

lpeabody commented 3 years ago

@lmakarov this might also fix the issue with having to perform a workaround to get vhost-proxy working correctly in GitHub Action linux environments.

lpeabody commented 3 years ago

@EggieCode I believe this will be fixed in #70.

EggieCode commented 3 years ago

Yes, Same as I have done on my machine. Thanks!