search

dockstore / dockstore

An app store for scientific workflows, tools, notebooks, and services
https://dockstore.org/
Apache License 2.0
120 stars 28 forks source link

Improve/remove default version name guessing logic in EntryVersionHelper #5103

Open svonworl opened 2 years ago

svonworl commented 2 years ago

Is your feature request related to a problem? Please describe. When a version name is not supplied, the sourcefile retrieval code in EntryVersionHelper attempts to guess a version name, based upon the entry type. After https://github.com/dockstore/dockstore/pull/5089, the code has been improved to guess latest for tools and master for workflows (whereas previously, it guessed latest for all types of entries). However, this is not perfect: https://github.com/github/renaming

It is possible that none of our code actually uses the "guessing logic"... that is, that we always supply a version name to the calls.

More discussion: https://github.com/dockstore/dockstore/pull/5089#discussion_r953888301

Describe the solution you'd like Inspect code to determine if the "guessing logic" is useful and/or used. Based upon conclusions, improve, remove, or leave as-is.

Describe alternatives you've considered Don't.

Additional context None.

┆Issue is synchronized with this Jira Story ┆Fix Versions: Open-ended research tasks ┆Issue Number: DOCK-2231 ┆Sprint: Backlog ┆Issue Type: Story

unito-bot commented 1 year ago

➤ Charles Overbeck commented:

Implementer could look at code coverage to see if at least our tests are hitting the code.