Closed ll5zh closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.52%. Comparing base (
c3fd1cb
) to head (32e3903
). Report is 2 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Description
[skipTests]
has a bug regarding double quotes in commit messages, discovered in this run: https://app.circleci.com/pipelines/github/dockstore/dockstore/11103/workflows/32fc7c3e-7ef6-4349-86a1-57993fec2401/jobs/42460. It looks like the command fails to process the " characters literally, causing syntax errors when exportingCOMMIT_MESSAGE
.Adding a command that substitutes instances of " with \" seems to resolve the issue, by escaping all double quotes (see https://app.circleci.com/pipelines/github/dockstore/dockstore/11107/workflows/76244033-1d18-4bb7-b748-6e76cdfb6fff/jobs/42481). On this branch, I also tried commit messages containing different special characters, to check that they can be properly exported as
COMMIT_MESSAGE
.Review Instructions From config.yml and the test commits, verify that commit messages containing double quotes (and other common, non-alphanumeric characters) are exported correctly (i.e.
COMMIT_MESSAGE
should be outputted properly).Are there any other special characters that might be found in commit messages, which haven't been attempted and might cause similar issues to the double quote?
Issue SEAB-5015 (https://oicr.slack.com/archives/C05EZH3RVNY/p1712251398680789)
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation