dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

Don't check OpenAPI for tag builds #5867

Closed coverbeck closed 2 months ago

coverbeck commented 2 months ago

Description If building a tag, don't check if the openapi is correct. We do something similar already here.

This is because of the way we do releases with the Maven plug-in. See "Dockstore Releases" Confluence page (intentionally not putting in the actual link) -- tags get created in that scenario without rebuilding.

Note that the openapi.yaml will be correct when publishing to Maven, because that is done in a different code path via GitHub actions, not in the config.yml.

Review Instructions

  1. Create a tag off develop branch: git tag 5867review
  2. git push --tags
  3. Wait for CircleCI build to complete
  4. Verify that the "Check Java imports sorted and OpenAPI" output does not contain the message "Checking openapi.yaml".
  5. Delete the test tag
    1. git tag push origin :5867review
    2. git tag --delete 5867review

Issue SEAB-6379

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

e.g. Does this change...

Please make sure that you've checked the following before submitting your pull request. Thanks!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.52%. Comparing base (7347da6) to head (2388791).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5867 +/- ## ============================================= + Coverage 74.49% 74.52% +0.02% - Complexity 5244 5245 +1 ============================================= Files 368 368 Lines 18945 18945 Branches 1992 1992 ============================================= + Hits 14114 14119 +5 + Misses 3880 3876 -4 + Partials 951 950 -1 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.23% <ø> (ø)` | | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `58.93% <ø> (+0.02%)` | :arrow_up: | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.08% <ø> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.71% <ø> (ø)` | | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.62% <ø> (ø)` | | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.58% <ø> (+<0.01%)` | :arrow_up: | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.88% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.