Closed denis-yuen closed 1 month ago
Attention: Patch coverage is 72.22222%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 74.49%. Comparing base (
1550b54
) to head (9197952
). Report is 2 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
(Codacy local variable suggestion intentionally ignored, probably don't want that to be garbage collected)
Failed conditions
73.9% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
Description
Follows https://github.com/dockstore/dockstore/pull/5872 but uses standard dropwizard metrics patterns. May make a little more sense to merge that one then look at "Files changed" for this one, but either way.
AWS CloudWatch output should stay the same (tested on qa)
For local output, add to web.yaml
and get console output
Review Instructions Same as the previous PR, look for metrics and auto-scaling rules in ECS linked to the new metrics. Created https://ucsc-cgl.atlassian.net/browse/SEAB-6402 for benchmarking
Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6401
Security and Privacy
Should be none, a little safer since metrics don't hitchhike on healthcheck
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation