Closed denis-yuen closed 1 month ago
Failed conditions
B Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 73.86%. Comparing base (
831453a
) to head (e9e2fc8
).
Files | Patch % | Lines |
---|---|---|
...ore/webservice/DockstoreWebserviceApplication.java | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description Ah math, it looks like AWS expects percentages out of a 100 rather than as a fraction as in Dropwizard Metrics. https://github.com/dockstore/dockstore/pull/5876
Output ends up looking like
Review Instructions See https://ucsc-cgl.atlassian.net/browse/SEAB-6143 apologies to https://ucsc-cgl.atlassian.net/browse/SEAB-6143 Apologies to @coverbeck
Issue Follow-up for https://github.com/dockstore/dockstore/pull/5873
Security and Privacy
None
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation