dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

unit fix for calculated load metric #5877

Closed denis-yuen closed 1 month ago

denis-yuen commented 1 month ago

Description Ah math, it looks like AWS expects percentages out of a 100 rather than as a fraction as in Dropwizard Metrics. https://github.com/dockstore/dockstore/pull/5876

Output ends up looking like

-- Gauges ----------------------------------------------------------------------
io.dropwizard.db.ManagedPooledDataSource.hibernate.active
             value = 25
io.dropwizard.db.ManagedPooledDataSource.hibernate.calculatedLoad
             value = 78.125
io.dropwizard.db.ManagedPooledDataSource.hibernate.idle
             value = 1
io.dropwizard.db.ManagedPooledDataSource.hibernate.size
             value = 25

Review Instructions See https://ucsc-cgl.atlassian.net/browse/SEAB-6143 apologies to https://ucsc-cgl.atlassian.net/browse/SEAB-6143 Apologies to @coverbeck

Issue Follow-up for https://github.com/dockstore/dockstore/pull/5873

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.86%. Comparing base (831453a) to head (e9e2fc8).

Files Patch % Lines
...ore/webservice/DockstoreWebserviceApplication.java 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5877 +/- ## ============================================= - Coverage 73.87% 73.86% -0.02% + Complexity 5263 5261 -2 ============================================= Files 371 371 Lines 19190 19190 Branches 2006 2006 ============================================= - Hits 14177 14175 -2 Misses 4057 4057 - Partials 956 958 +2 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.13% <50.00%> (-0.02%)` | :arrow_down: | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `58.46% <50.00%> (-0.01%)` | :arrow_down: | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.07% <50.00%> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.69% <50.00%> (-0.01%)` | :arrow_down: | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.50% <50.00%> (-0.01%)` | :arrow_down: | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.47% <50.00%> (-0.01%)` | :arrow_down: | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.64% <50.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.