Closed svonworl closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.89%. Comparing base (
e6d0782
) to head (244c9c9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description This PR changes the webservice to no longer periodically log information about the database pool. As of https://github.com/dockstore/dockstore/pull/5873, we now submit database pool information as CloudWatch metrics. I left the corresponding logging method in the helper class, so we can call it from other code if we need to. For example, given some particular exceptional condition, we might invoke it from adjacent code to give us more details, or similar.
We still periodically log:
df
output)As part of this ticket, I thought about whether we could summarize either of the above as metrics and eliminate the logging.
Regarding the filesystem information, the logical summary metric is "how much file storage is available/consumed?", which we'll probably add as part of https://ucsc-cgl.atlassian.net/browse/SEAB-4906. However, the
df
output could very well contain subtle clues that are diagnostically valuable.It's more difficult to figure out how to summarize the memory pool details. Within, there's lots of different information that could be useful in various situations.
So, for now, we'll continue to periodically log filesystem and memory pool info. The details of both could help us to reason about previously-unencountered forms of space and memory problems.
Review Instructions Check the logs, and confirm that database pool information is no longer periodically logged.
Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6388
Security and Privacy
No concerns.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation