dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

SEAB-6420: Add new health check names to endpoint `allowableValues` #5883

Closed svonworl closed 1 month ago

svonworl commented 1 month ago

Description This PR adds liquibaseLock and elasticSearchConsistency to the list of allowed values for the include parameter of the health check endpoint. It also removes the obsolete @ApiParam annotation.

Review Instructions Confirm that the new values appear in openapi.yaml.

Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6420

Security and Privacy

No concerns.

e.g. Does this change...

Please make sure that you've checked the following before submitting your pull request. Thanks!

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.81%. Comparing base (142f581) to head (b698290).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5883 +/- ## ============================================= - Coverage 73.83% 73.81% -0.02% + Complexity 5265 5263 -2 ============================================= Files 371 371 Lines 19211 19211 Branches 2012 2012 ============================================= - Hits 14184 14181 -3 - Misses 4070 4072 +2 - Partials 957 958 +1 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.11% <ø> (-0.01%)` | :arrow_down: | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `58.43% <ø> (ø)` | | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.07% <ø> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.68% <ø> (ø)` | | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.47% <ø> (ø)` | | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.33% <ø> (-0.12%)` | :arrow_down: | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.65% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.