Closed coverbeck closed 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.73%. Comparing base (
0430bbe
) to head (d726867
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description We were considering all active DB connections in use as meaning the container is unhealthy. But it doesn't necessarily mean that, it could be the results of a wave of requests. If that's the case, marking the container unhealthy will only exacerbate the problem, as it can push more load on the healthy containers, making them unhealthy, etc. See SEAB-4879's comments, where this is discussed in more detail.
We could just remove the health check entirely, but then it's another PR to dockstore-deploy to not invoke the check. I figured it was better/easier to keep the framework and log a message. And if we find a way to determine unhealthiness in the future, the scaffolding is there. But if others feel we should just remove the check entirely, please opine.
Review Instructions Hard to review, try to slam environment to chew up DB connections, and make sure that container does not get shut down due to being unhealthy. Even without this change, I've been unable to make the container go unhealthy, so it will be hard to verify. Make sure there's no regression at least.
Issue SEAB-4879
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation