dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

"Cite all versions" DOI is unclear, and also wrong #5892

Closed aofarrel closed 2 weeks ago

aofarrel commented 1 month ago

Describe the bug While looking into https://github.com/dockstore/dockstore/issues/5891, I found a fifth(!) DOI appeared in my workflow. This DOI is an invalid link and doesn't seem to match any of the DOIs mentioned in that ticket. This shows in both my-workflows view and also the public view:

I eventually realized the 11237485 DOI is actually the cite-all-versions DOI:

Except there's two problems:

To Reproduce It seems very likely this is totally separate from the disappearing DOI issue discussed in https://github.com/dockstore/dockstore/issues/5891, so reproducing should just be:

  1. Make a DOI of some version of a workflow
  2. Make a DOI of another version of a workflow
  3. See a third DOI in the workflow view that is unclearly labeled, and also an invalid link

Expected behavior

Additional context [Domain] - https://dockstore.org Webservice

┆Issue is synchronized with this Jira Story ┆Attachments: image-20240610-175828.png | image-20240610-175856.png ┆Fix Versions: Dockstore 1.16 ┆Issue Number: DOCK-2527 ┆Sprint: 138 - Keelung ┆Issue Type: Story

denis-yuen commented 1 month ago

I think this is https://github.com/dockstore/dockstore/issues/5875 (at least the broken link part)

aofarrel commented 1 month ago

Ooh, yep, #5875 beat me to the punch. I do think there is still a UI issue because it's not clear what the concept DOI is in the first place, but feel free to adjust this into an enhancement ticket as needed.

unito-bot commented 2 weeks ago

➤ David Steinberg commented:

Confirmed the Concept DOI shows up and is different from the version DOI

!image-20240610-175828.png|width=355,height=324,alt="image-20240610-175828.png"!

!image-20240610-175856.png|width=981,height=230,alt="image-20240610-175856.png"!

[Domain] - https://qa.dockstore.org ( https://qa.dockstore.org|smart-link )

Webservice ( https://github.com/dockstore/dockstore/commits/2446190 ) - 2446190

UI ( https://github.com/dockstore/dockstore-ui2/commits/e403975e ) - 2.12.2-58-ge403975e

Deploy ( https://github.com/dockstore/dockstore-deploy/commits/824ceb9 ) - 1.15.1-47-g824ceb9

cwlParsingLambdaVersion: n/a

wdlParsingLambdaVersion: n/a

nextflowParsingLambdaVersion: n/a

galaxyParsingLambdaVersion: 0.0.6

checkUrlLambdaVersion: n/a