dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

DOCK-2523: Fix formatting of conceptDOI #5894

Closed hyunnaye closed 3 weeks ago

hyunnaye commented 1 month ago

Description This PR removes the doi/ prefix in conceptDOI

Review Instructions Go to https://qa.dockstore.org/workflows/github.com/kathy-t/ghapps-single-workflow:master?tab=info and verify that the link works correctly.

Issue https://ucsc-cgl.atlassian.net/browse/DOCK-2523 https://ucsc-cgl.atlassian.net/browse/DOCK-2527

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

e.g. Does this change...

Please make sure that you've checked the following before submitting your pull request. Thanks!

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 70.05%. Comparing base (e6eea04) to head (c89dd09).

:exclamation: Current head c89dd09 differs from pull request most recent head b2fd097

Please upload reports for the commit b2fd097 to get more accurate results.

Files Patch % Lines
.../io/dockstore/webservice/helpers/ZenodoHelper.java 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5894 +/- ## ============================================= - Coverage 73.61% 70.05% -3.57% + Complexity 5298 4955 -343 ============================================= Files 374 371 -3 Lines 19404 19192 -212 Branches 2021 2012 -9 ============================================= - Hits 14284 13444 -840 - Misses 4150 4765 +615 - Partials 970 983 +13 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.15% <0.00%> (+0.10%)` | :arrow_up: | | [hoverflytests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `?` | | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `49.65% <0.00%> (-7.32%)` | :arrow_down: | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.08% <0.00%> (-0.01%)` | :arrow_down: | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.70% <0.00%> (+0.06%)` | :arrow_up: | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.50% <0.00%> (+0.11%)` | :arrow_up: | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.45% <0.00%> (+2.40%)` | :arrow_up: | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5894/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.70% <0.00%> (+4.48%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

denis-yuen commented 1 month ago

The ticket has a 1.15.x milestone, should the base be changed to the hotfix branch?

I think it's worth considering depending on how invasive this all ends up being. Let's see what the migration ends up looking like.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint