dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

modest update bouncycastle via transitive #5895

Closed denis-yuen closed 3 weeks ago

denis-yuen commented 4 weeks ago

Description See issue for extended notes.

Review Instructions Try metrics retrieval and old verified workflow logs (will communicate with AWS and thus hopefully use encryption) Try updating a workflow with a Docker image and see whether checksums and the like are recorded correctly.

Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6461

Security and Privacy

None, upgrade is intended to address CVEs

Please make sure that you've checked the following before submitting your pull request. Thanks!

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.79%. Comparing base (b769e72) to head (adc1d68).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5895 +/- ## ============================================= + Coverage 73.73% 73.79% +0.06% - Complexity 5260 5263 +3 ============================================= Files 371 371 Lines 19207 19207 Branches 2012 2012 ============================================= + Hits 14162 14174 +12 + Misses 4090 4078 -12 Partials 955 955 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.18% <ø> (+0.05%)` | :arrow_up: | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `58.37% <ø> (ø)` | | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.07% <ø> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.68% <ø> (ø)` | | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.48% <ø> (ø)` | | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.45% <ø> (ø)` | | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.67% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

denis-yuen commented 4 weeks ago

FYI, snyk still think's there's an issue with the newest version, but I think it's a false positive due to the way dependencyManagement works in Maven