Closed denis-yuen closed 3 weeks ago
Attention: Patch coverage is 75.00000%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 74.54%. Comparing base (
6370175
) to head (fac977c
).:exclamation: Current head fac977c differs from pull request most recent head 3010305
Please upload reports for the commit 3010305 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
...ces/proposedGA4GH/ToolsApiExtendedServiceImpl.java | 67.85% | 5 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
5 New issues
0 Accepted issues
Measures
0 Security Hotspots
83.9% Coverage on New Code
0.0% Duplication on New Code
After we generate an AI topic, we save the request that we submitted to the AI system, in the form of a hash of the request. Then, to test if we need to regenerate, build the request that corresponds to the current entry state, hash it, and if differs from the saved hash, submit the request to the AI system to regenerate the topic.
Not exactly an objection, but I would like the first pass to be relatively simple and then we can collect data on effectiveness, billing, etc. before deciding to optimise (or prematurely optimise?) more and in what way we optimise. It may be the case that the cost is low enough that we can blank everything and then just re-generate on everything without a topic set in some other way without worrying about it much.
Going to create https://ucsc-cgl.atlassian.net/browse/SEAB-6484 for further discussion on this and the "what branch or tag" to consider question.
Also followed by https://ucsc-cgl.atlassian.net/browse/SEAB-6485 for the CLI portion
(hoverfly failure seems to be separate issue from develop, noted in #dockstore)
Description Add a field to record what versions have been used for topic generation (and clears it if it is updated). Add an endpoint to return a latest version for consideration for topic generation.
Will need minor dockstore-support following PR
Review Instructions n/a probably will need dockstore-support follow-up
Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6465
Security and Privacy
None
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation