dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

SEAB-6465 Add DB fields to aid periodic tasks - topics #5897

Closed denis-yuen closed 3 weeks ago

denis-yuen commented 4 weeks ago

Description Add a field to record what versions have been used for topic generation (and clears it if it is updated). Add an endpoint to return a latest version for consideration for topic generation.

Will need minor dockstore-support following PR

Review Instructions n/a probably will need dockstore-support follow-up

Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6465

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.54%. Comparing base (6370175) to head (fac977c).

:exclamation: Current head fac977c differs from pull request most recent head 3010305

Please upload reports for the commit 3010305 to get more accurate results.

Files Patch % Lines
...ces/proposedGA4GH/ToolsApiExtendedServiceImpl.java 67.85% 5 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5897 +/- ## ============================================= + Coverage 71.27% 74.54% +3.26% - Complexity 5178 5364 +186 ============================================= Files 374 374 Lines 19396 19439 +43 Branches 2021 2029 +8 ============================================= + Hits 13825 14490 +665 + Misses 4637 3976 -661 - Partials 934 973 +39 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.00% <5.55%> (-0.05%)` | :arrow_down: | | [hoverflytests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.44% <11.11%> (?)` | | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `57.00% <75.00%> (+0.01%)` | :arrow_up: | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.08% <5.55%> (-0.02%)` | :arrow_down: | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.61% <5.55%> (-0.04%)` | :arrow_down: | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.35% <11.11%> (-0.05%)` | :arrow_down: | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `26.01% <11.11%> (-0.02%)` | :arrow_down: | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.36% <11.11%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

denis-yuen commented 3 weeks ago

After we generate an AI topic, we save the request that we submitted to the AI system, in the form of a hash of the request. Then, to test if we need to regenerate, build the request that corresponds to the current entry state, hash it, and if differs from the saved hash, submit the request to the AI system to regenerate the topic.

Not exactly an objection, but I would like the first pass to be relatively simple and then we can collect data on effectiveness, billing, etc. before deciding to optimise (or prematurely optimise?) more and in what way we optimise. It may be the case that the cost is low enough that we can blank everything and then just re-generate on everything without a topic set in some other way without worrying about it much.

Going to create https://ucsc-cgl.atlassian.net/browse/SEAB-6484 for further discussion on this and the "what branch or tag" to consider question.

denis-yuen commented 3 weeks ago

Also followed by https://ucsc-cgl.atlassian.net/browse/SEAB-6485 for the CLI portion

denis-yuen commented 3 weeks ago

(hoverfly failure seems to be separate issue from develop, noted in #dockstore)