dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

version filter clashed with getAuthors #5898

Open denis-yuen opened 3 weeks ago

denis-yuen commented 3 weeks ago

Describe the bug

2024-05-30T07:02:00.279-04:00 127.0.0.1 - - [30/May/2024:11:02:00 +0000] "GET /metadata/sourceControlList HTTP/1.0" 200 201 "-" "ELB-HealthChecker/2.0" 0 2024-05-30T07:02:00.309-04:00 ERROR [2024-05-30 11:02:00,309] io.swagger.api.impl.ToolsImplCommon: version filter clashed with geetAuthors ERROR [2024-05-30 11:02:00,309] io.swagger.api.impl.ToolsImplCommon: version filter clashed with geetAuthors 2024-05-30T07:02:00.309-04:00 org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [io.dockstore.webservice.core.WorkflowVersion#193911]

May be first to be caught by more sensitive 500 threshold since I only found two errors in CloudWatch

- - [30/May/2024:11:09:45 +0000] "GET /api/ga4gh/trs/v2/tools/%23workflow%2Fgithub.com%2Fiwc-workflows%2Fsars-cov-2-pe-illumina-artic-variant-calling%2FCOVID-19-PE-ARTIC-ILLUMINA HTTP/1.1" 500 334 "-" "go-resty/2.10.0 (https://github.com/go-resty/resty)" 10.0.1.43 1.011 - - [30/May/2024:11:09:45 +0000] "GET /api/ga4gh/trs/v2/tools/%23workflow%2Fgithub.com%2Fiwc-workflows%2Fsars-cov-2-pe-illumina-artic-variant-calling%2FCOVID-19-PE-ARTIC-ILLUMINA HTTP/1.1" 500 334 "-" "go-resty/2.10.0 (https://github.com/go-resty/resty)" 10.0.1.43 1.011

To Reproduce Unclear, workflow is https://dockstore.org/workflows/github.com/iwc-workflows/sars-cov-2-pe-illumina-artic-variant-calling/COVID-19-PE-ARTIC-ILLUMINA:main?tab=info but you can't simply call

https://dockstore.org/api/ga4gh/trs/v2/tools/%23workflow%2Fgithub.com%2Fiwc-workflows%2Fsars-cov-2-pe-illumina-artic-variant-calling%2FCOVID-19-PE-ARTIC-ILLUMINA to reproduce

Since the code in question was noted to have issues with the new version of Hibernate https://github.com/dockstore/dockstore/blame/2f81db3457d3227bcc03449bc80ad490cfba1ef8/dockstore-webservice/src/main/java/io/swagger/api/impl/ToolsImplCommon.java#L184 it could be an edge case where two transactions interfere with each other

Screenshots

[Domain] - https://dockstore.org

Webservice

UI

Deploy

┆Issue is synchronized with this Jira Story ┆Issue Number: DOCK-2528 ┆Sprint: 141 - Narbo ┆Issue Type: Story