dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

Back button no longer works when visiting a 404 user/org/workflow #5900

Open david4096 opened 3 weeks ago

david4096 commented 3 weeks ago

Describe the bug

When visiting a bad username, org name, or workflow name the browser will get stuck on the Page Not Found page.

To Reproduce

  1. browse dockstore
  2. visit https://dockstore.org/users/notauser334234
  3. try going back and observe the browser continuously redirecting to Page Not Found

Note, this does not happen for top level pages like https://dockstore.org/organiz but does happen for organizations that do not exist like https://dockstore.org/organizations/notanorg

Expected behavior

It should be possible to go back through without the browser getting stuck in a history loop

Screenshots

Desktop (please complete the following information):

ubuntu firefox 126.0 (64-bit)

Additional context

[Domain] - https://dockstore.org

Webservice - 1.15.2

UI - 2.12.1

Deploy - 1.15.0

┆Issue is synchronized with this Jira Story ┆Issue Number: DOCK-2530 ┆Sprint: Backlog ┆Issue Type: Story

denis-yuen commented 3 weeks ago

Other examples at https://oicr.slack.com/archives/C05EZH3RVNY/p1717095112252929