dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

Fix DOI migration #5902

Closed kathy-t closed 3 weeks ago

kathy-t commented 3 weeks ago

Description Follow up to https://github.com/dockstore/dockstore/pull/5879. Upon merging it to develop, the Deploy Develop Snapshot GitHub Action failed the generate database documentation step because subquery in FROM must have an alias. This PR fixes that error by adding an alias for the subquery

Review Instructions Snapshot action should pass

Issue https://ucsc-cgl.atlassian.net/browse/SEAB-5929 https://ucsc-cgl.atlassian.net/browse/SEAB-6371

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

e.g. Does this change...

Please make sure that you've checked the following before submitting your pull request. Thanks!

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.53%. Comparing base (e6eea04) to head (460cd1a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5902 +/- ## ============================================= + Coverage 73.61% 74.53% +0.91% - Complexity 5298 5352 +54 ============================================= Files 374 374 Lines 19404 19404 Branches 2021 2021 ============================================= + Hits 14284 14462 +178 + Misses 4150 3972 -178 Partials 970 970 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.04% <ø> (-0.01%)` | :arrow_down: | | [hoverflytests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.47% <ø> (ø)` | | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `56.96% <ø> (ø)` | | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `11.09% <ø> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.63% <ø> (ø)` | | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.38% <ø> (-0.02%)` | :arrow_down: | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `26.04% <ø> (ø)` | | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.40% <ø> (+4.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.