Closed svonworl closed 2 weeks ago
Attention: Patch coverage is 84.61538%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 74.55%. Comparing base (
b881d9c
) to head (fdb67c6
).:exclamation: Current head fdb67c6 differs from pull request most recent head 38b28c1
Please upload reports for the commit 38b28c1 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
...ckstore/webservice/resources/WorkflowResource.java | 84.61% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code
Description As part of the investigation of https://ucsc-cgl.atlassian.net/browse/SEAB-6448 and https://ucsc-cgl.atlassian.net/browse/SEAB-6449 (see Slack thread https://ucsc-gi.slack.com/archives/C05EZH3RVNY/p1717540768164039), we found via testing that a workflow owner can restub .dockstore.yml-based workflows via the API, and probably update them via various other
WorkflowResource
endpoints intended only for use on STUB/FULL workflows. This PR changes these endpoints to gracefully refuse to update .dockstore.yml-based workflows.Review Instructions Create a .dockstore.yml-based workflow on qa, then attempt to restub it via the API. The attempt should fail with a BAD_REQUEST response code and a useful error message.
Issue https://ucsc-cgl.atlassian.net/browse/SEAB-6448 https://ucsc-cgl.atlassian.net/browse/SEAB-6449
Security and Privacy
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation