dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

fix regex for comments in .dockstore.yml and add test #5910

Closed denis-yuen closed 1 week ago

denis-yuen commented 2 weeks ago

Description Need to account for comments on version line, added test as well. Good explainer at https://regex101.com/r/JkeO0N/1 or https://xkcd.com/1171/

Review Instructions Can fork test workflow and register/use it

Issue https://github.com/dockstore/dockstore/issues/5904

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.39%. Comparing base (b7858a6) to head (8b7444b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## hotfix/1.15.3 #5910 +/- ## ================================================ Coverage 74.38% 74.39% - Complexity 5268 5269 +1 ================================================ Files 365 365 Lines 19047 19047 Branches 2021 2021 ================================================ + Hits 14169 14170 +1 Misses 3916 3916 + Partials 962 961 -1 ``` | [Flag](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | Coverage Δ | | |---|---|---| | [bitbuckettests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `27.04% <0.00%> (-0.01%)` | :arrow_down: | | [integrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `58.22% <100.00%> (ø)` | | | [languageparsingtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `10.85% <0.00%> (ø)` | | | [localstacktests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `21.50% <0.00%> (ø)` | | | [toolintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `30.37% <0.00%> (ø)` | | | [unit-tests_and_non-confidential-tests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `28.72% <100.00%> (ø)` | | | [workflowintegrationtests](https://app.codecov.io/gh/dockstore/dockstore/pull/5910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore) | `38.66% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dockstore#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud