dockstore / dockstore

Our VM/Docker sharing infrastructure and management component
https://dockstore.org/
Apache License 2.0
116 stars 27 forks source link

Console Error and Infinite Progress if you navigate to a workflow then a tool #5927

Open coverbeck opened 2 weeks ago

coverbeck commented 2 weeks ago

Describe the bug If you navigate to a workflow, then to a tool, the progress bar never stops on the tool page. If you have the console open, you can see some failed requests.

Happens in prod, staging and QA.

To Reproduce Steps to reproduce the behavior:

  1. Click on Search menu item
  2. Click on the first workflow in the results (but it doesn't matter which one)
  3. Click on Search menu item
  4. Click on Tools tab, then the first tool in the results (but it also doesn't matter which one)
  5. When you get to the tools page, note how the progress bar is going and going
  6. If you'd opened browser tools, you'd see a 404 network error on, for example, https://qa.dockstore.org/api/workflows/path/workflow/quay.io%2Fpancancer%2Fpcawg-sanger-cgp-workflow/published?include=validations,authors,metrics&subclass=APPTOOL

If you do a browser refresh of the tool page, note that the path of the above request is https://qa.dockstore.org/api/containers/path/tool/quay.io%2Fpancancer%2Fpcawg-sanger-cgp-workflow/published?include=validations -- there no subclass query param, nor the the authors nor metrics values for include. Probably a shared component is not resetting some values.

Expected behavior The progress bar should stop moving, no errors in console.

Additional context [Domain] - https://qa.dockstore.org

Webservice

UI

Deploy

cwlParsingLambdaVersion: n/a

wdlParsingLambdaVersion: n/a

nextflowParsingLambdaVersion: n/a

galaxyParsingLambdaVersion: 0.0.6

checkUrlLambdaVersion: n/a

┆Issue is synchronized with this Jira Story ┆Fix Versions: Dockstore 1.15.x ┆Issue Number: DOCK-2544 ┆Sprint: 141 - Narbo ┆Issue Type: Story

unito-bot commented 2 weeks ago

➤ Steve Von Worley commented:

Probably should add a test that covers this, too.