search

dockwa / simple-react-validator

A simple react form validator inspired by Laravel validation.
https://dockwa.github.io/simple-react-validator
MIT License
276 stars 77 forks source link

Turkish Language Locale file should be added #181

Closed oguzhanozpinar closed 4 years ago

oguzhanozpinar commented 4 years ago

To use this library on a local project, I want to add Turkish languıage file

oguzhanozpinar commented 4 years ago

While following the process you mentioned in CONTRIBUTING.md, when I run the command npm install , it producess an error : image

Only improvement that I have done is adding tr.js file

stuyam commented 4 years ago

Here is a helpful link to help Turkish translations: https://github.com/caouecs/Laravel-lang/blob/master/src/tr/validation.php

As for the error you are seeing, looks like something lower level. I would suggest you are running a newer version of npm. Im running npm 6.13.0 and it works for me right out of the box on mac.

oguzhanozpinar commented 4 years ago

I suspect that error is caused by my node version, may I learn yours ? As I researched, node 12 and gulp 3 wont work together

stuyam commented 4 years ago 
> node -v
v10.16.0
> npm -v
6.13.0
stuyam commented 4 years ago

I think I had to downgrade for a different project recently and haven't upgraded again. I should be testing on the latest I thought I was.

stuyam commented 4 years ago

I upgraded to:

> node -v
v13.5.0
> npm -v
6.13.4

and now I am getting the same error as you.

oguzhanozpinar commented 4 years ago

https://stackoverflow.com/questions/55921442/how-to-fix-referenceerror-primordials-is-not-defined-in-node

stuyam commented 4 years ago

Well this seems like another issue, but for now you can just add the Turkish file without building to open a PR and Ill make a new issue regarding the node gulp issue.

oguzhanozpinar commented 4 years ago

I am currently testing it on my project. As soon as I implement it, i will open a PR.

oguzhanozpinar commented 4 years ago

No matter how I try i could not make it work. I also tried the existing language supports but they are also seem not to work. I couldnt find any existing issues related to localization.

stuyam commented 4 years ago

@oguzhanozpinar I just upgraded to gulp 4 and it seems to be working locally now. I also tested the French locale locally and that seemed to work too. Give it another try and keep me posted, I can help you if you run into trouble, but you should just be able to make the new locale in src/locale/ and that would be all, then I can build for release.