search

doclin-dev / doclin

Server and VS Code Extension of Doclin
https://doclin.dev
GNU Affero General Public License v3.0
44 stars 22 forks source link

Anonymous replies reveals name during email notification #132

Closed shawonibnkamal closed 1 month ago

shawonibnkamal commented 2 months ago

Doclin allows user to submit threads anonymously.

image

When user tags someone's name in the thread, the tagged person receives an email notification. Currently, the email notification reveals the thread creators name which is a privacy breach.

Take a look at threadController.postThread. We need to pass in the anonymous check as an argument to sendMentionEmailNotification. Then use an condition to prevent senderName from revealing with the anonymous check is set to true.

abhedanil commented 2 months ago

Please assign it to me

abhedanil commented 1 month ago

Hi @shawonibnkamal , I've implemented the changes to ensure anonymous thread submissions do not reveal the sender's name in email notifications. I haven't been able to test this thoroughly due to some local setup issues. Could you please review the changes and suggest any necessary adjustments?

PR: https://github.com/doclin-dev/doclin/pull/140

Thank you!

shawonibnkamal commented 1 month ago

Hi @shawonibnkamal , I've implemented the changes to ensure anonymous thread submissions do not reveal the sender's name in email notifications. I haven't been able to test this thoroughly due to some local setup issues. Could you please review the changes and suggest any necessary adjustments?

PR: #140

Thank you!

Thanks! Left some comments on your PR. Can you share what local setup issues you are facing? I can help fix those and improve the documentation as needed.

abhedanil commented 1 month ago

Update the PR (https://github.com/doclin-dev/doclin/pull/140) with suggested changes . I am not able the test the api endpoint to test the functionality in local