Closed abhedanil closed 1 month ago
Hi @shawonibnkamal , by following my method we can avoid a db operation right ? In your suggested method we are trying to fetch details without checking the the message is anonymous or not . Correct me if i am wrong .
Hi @shawonibnkamal , by following my method we can avoid a db operation right ? In your suggested method we are trying to fetch details without checking the the message is anonymous or not . Correct me if i am wrong .
Good point! Yes, you can do it your way as long as the constant string is defined on top of the file and the formatting issues are fixed.
I made All the changes you suggested .
ANONYMOUS_USER
at the top constant for cleaner code.anonymous
to false
to maintain compatibility with replyController
.25e84f1a26e82f8c8f4b1c18fd6e18612a5c8d5f
Thanks @abhedanil, code tested good! Would you be able to run npm run prettier-fix
again? The formatting issue does not seem to be fixed, I wonder if prettier is not working as expected.
Also, can you let me know what trouble you are having with the local setup? Your feedback will help improve the local setup.
HI, @shawonibnkamal formatted the code . The local issue i am facing was i couldn't trigger the api edpoint for creating threads.
HI, @shawonibnkamal formatted the code . The local issue i am facing was i couldn't trigger the api edpoint for creating threads.
How were you trying to test it? Did you run the extension and server locally?
Hi @abhedanil, also noticed your commit isn't connected to your github account. You may want to set it up correctly, if you want all your commits and activity to show up in your github profile.
Its seems my git config changed somehow. Can i add a comment in the code and so it counts on my contribution ?
Actually i was not able to test the reply and post thread in local because i was not able to trigger api by curl or postman . If you can guide me through the steps i will be able to take other tasks too.
Its seems my git config changed somehow. Can i add a comment in the code and so it counts on my contribution?
For sure! You can refactor or clean up any unclean code. We avoid inline comments unless necessary. I should be able to add some easy tasks by the weekend if you're interested.
Actually i was not able to test the reply and post thread in local because i was not able to trigger api by curl or postman . If you can guide me through the steps i will be able to take other tasks too.
You don't need to use postman. Were you able to run the extension locally? You should be able to test your local server easily using the extension in debugger mode.
Sure . Please assign some more task if possible , i can take up that. I will try to run the extension next time . Thanks.
Description
This pull request addresses the issue of revealing the thread creator's name in email notifications when the thread is posted anonymously. The following changes were made:
Added an
anonymous
parameter to thesendMentionEmailNotification
function.postThread
function to pass theanonymous
parameter.Checklist