search

doclin-dev / doclin

Server and VS Code Extension of Doclin
https://doclin.dev
GNU Affero General Public License v3.0
44 stars 22 forks source link

Replying to threads is not sending notification #141

Closed shawonibnkamal closed 1 month ago

shawonibnkamal commented 1 month ago

In replyController.ts, sending notification is being handled under sendEmailNotification method.

const allRelevantUserIds = [...new Set([...mentionedUserIds, ...relevantUserIds])];

if (mentionedUserIds.length > 0) {
  sendMentionEmailNotification(
    userId,
    allRelevantUserIds,
...

The if statement is using the wrong variable. It should check the length of allRelevantUserIds instead.

temideewan commented 1 month ago

@shawonibnkamal I'd like to take this up

shawonibnkamal commented 1 month ago

Thank you @temideewan, I assigned you this issue.