search

docmeta / rubydoc.info

Next generation rdoc.info site
http://rubydoc.info
MIT License
132 stars 43 forks source link

safe_mode whitelist for facterdb #191

Open yakatz opened 3 months ago

yakatz commented 3 months ago

Most people using the facterdb gem will be looking for the documentation about which versions of our factsets are included in the gem, as opposed to how to actually use the API, so we have a custom template to focus on that. Can facterdb be added to your whitelisted_gems list?

lsegal commented 3 months ago

Done :)

yakatz commented 3 months ago

Thanks. It looks like it doesn't include the css (i.e. it is showing a 404), or if it does, the location is wrong. Any ideas?

lsegal commented 3 months ago

@yakatz this might be an issue with relative / global paths, or possibly due to the way we "install" custom plugin CSS. I think we might need to patch something to get that to work. Haven't had any custom templates/plugins that pull in assets before. One workaround would just be to inline the css where you need it for now (though this won't necessarily help with images unless you want to data-url those as well, not exactly ideal).

PS: noticed that you created a custom facterdb template and recreated all the template files-- you can avoid this by just using default and overriding individual templates that you actually need: https://github.com/docmeta/rubydoc.info/tree/main/templates/default