Fix/export operator symbol

docopt / docopt.cpp

C++11 port of docopt

Boost Software License 1.0

1.04k stars 146 forks source link

Fix/export operator symbol #117

Closed theodelrieu closed 2 years ago

theodelrieu commented 4 years ago

Hi Jared,

I know some PRs are already opened to fix both issues fixed by this one (i.e. DLL interface for operator<< and building only one target at a time), but they are stalling since a few months right now, so I hope this will make it go forward 😄

theodelrieu commented 4 years ago

Those patches have been applied in the conan-center-index related PR, which builds a lot of Windows configurations. If the CI passes there, it should be good!

theodelrieu commented 4 years ago

Seems like Travis is unhappy about some packages to install

tdegeus commented 4 years ago

@theodelrieu Any chance that you know what is going on in #124 ?

jaredgrubb commented 4 years ago

This looks good, though I'm not a Cmake pro so would love to have someone else +1 this just so we get someone qualified to look!

tdegeus commented 4 years ago

I can confirm that it fixes #125 . (I haven't dived in to the details of the rest of the change.)

jaredgrubb commented 2 years ago

This PR had a merge issue, and I couldn't figure out how to resolve it here, so I just cloned the branch and fixed in. Merged in #151.

jaredgrubb commented 2 years ago

Thanks for the work!