search

docopt / docopt.cpp

C++11 port of docopt
Boost Software License 1.0
1.05k stars 146 forks source link

reserved identifier violation #15

Closed elfring closed 9 years ago

elfring commented 9 years ago

I would like to point out that an identifier like "__docopt__value__" does not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

jaredgrubb commented 9 years ago

Yes we should.

jaredgrubb commented 9 years ago

I have pushed a fix for this. Thanks for the report!

elfring commented 9 years ago

How do you think about to change also any remaining double underscores in affected identifiers?

jaredgrubb commented 9 years ago

Are there still some?

elfring commented 9 years ago

Yes. - I find that your fix was incomplete a moment ago.

jaredgrubb commented 9 years ago

I did a grep for “__” in the sources and am unable to find anything left. Can you be more specific on what is still missing?

elfring commented 9 years ago

I suggest to drop another underscore from a prefix like "docopt__" for example.