search

docpad / docpad-plugin-cleanurls

Adds support for clean urls to DocPad
Other
21 stars 13 forks source link

hard-coded static env name #5

Open 1000i100 opened 11 years ago

1000i100 commented 11 years ago

line 80 in your src plugin code there is :

Static

if 'static' in docpad.getEnvironments()

the static features could also be triggered by a custom parameters to not enforce static env name use. It could improve compatibility with other plugin using env specific rules.

balupton commented 11 years ago

Nice suggestion :+1: Any thoughts on what a possible implementation could look like?

1000i100 commented 11 years ago

i'm not enough familiar with docpad internals to know how to add custom parameters in config files or command line. Perhaps some time later, right now, i'm just discovering and testing docpad ecosystem.

balupton commented 11 years ago

Cool, no worries.

RobLoach commented 10 years ago

https://github.com/docpad/docpad-plugin-cleanurls/pull/14 ?

balupton commented 10 years ago

Fixed in v2.7.0. Note that I've made some changes, see the readme.