search

docpad / docpad-plugin-thumbnails

DocPad plugin that manages thumbnail generation of your image files
Other
18 stars 6 forks source link

Incompatible with DocPad v6.80 and above #17

Open cattermo opened 6 years ago

cattermo commented 6 years ago

Plugin requires updating to CoffeeScript v2. This can be done automatically via running https://github.com/bevry/boundation on it. If you would like the DocPad team to do it, then transfer the repo to the https://github.com/docpad organisation, and run the following:

npm owner add balupton docpad-plugin-assets npm owner add bevryme docpad-plugin-assets

rantecki commented 6 years ago

I'm happy to transfer this, but I need permission to create repo's on the 'docpad' organisation to do so?

rantecki commented 6 years ago

FYI - I've updated the npm package owners

balupton commented 6 years ago

Just added @rantecki to the docpad extras team, once you accept you should be able to transfer

rantecki commented 6 years ago

Ok, this is done.

balupton commented 6 years ago

Great, I'll get to the upgrade with the rest of them.

fmanaya commented 6 years ago

Sorry, I just saw this issue after fork and work upgrading this plugin. This is the repo https://github.com/fmanaya/docpad-plugin-thumbnails. I make changes from plugin template (docpad-plugin-yourpluginname) and not using boundation. Unfortunately I'am not able tu pass the tests. I think it fail first on constructor... So, after this issue, I am not sure what is the way. If you transfer and upgrade this plugin soon i can wait. If not, maybe you can give me some hint to fix it. Thank you very match

balupton commented 6 years ago

I've got this plugin converted locally but got some spontaneous failing tests, more details here:

https://github.com/docpad/docpad-plugin-assets/issues/5#issuecomment-425911371

I'll have a fix out hopefully next week (requires some changes to docpad-plugintester). Got a few time critical tasks to knock off first though.